Skip to content

[risk=no][RW-7215]Add admin_test_user to e2e config,yarn,readme,env #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 24, 2021
Merged

[risk=no][RW-7215]Add admin_test_user to e2e config,yarn,readme,env #5461

merged 7 commits into from
Aug 24, 2021

Conversation

chavanr2019
Copy link
Contributor

@chavanr2019 chavanr2019 commented Aug 20, 2021 •
edited
Loading

Description:

  • added the ADMIN_TEST_USER env variables and emails to the files.

PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have run and tested this change locally
  • I have run the E2E tests on ths change against my local UI and/or API server with yarn test-local or yarn test-local-devup
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer
  • If this includes an API change, I have updated the appropriate Swagger definitions and notified API consumers
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later

@chavanr2019 chavanr2019 requested review from aweng98, calbach and jmthibault79 and removed request for calbach August 20, 2021 19:03
calbach
calbach approved these changes Aug 20, 2021
View reviewed changes
.circleci/export-e2e-test-user-vars.sh
echo "export COLLABORATOR_USER=$PUPPETEER_COLLABORATOR_STAGING" >> "$BASH_ENV"
echo "export USER_NAME=$PUPPETEER_USER_STAGING" >> "$BASH_ENV"
echo "export ACCESS_TEST_USER=$PUPPETEER_ACCESS_STAGING" >> "$BASH_ENV"
echo "export ADMIN_TEST_USER=$PUPPETEER_ADMIN_STAGING" >> "$BASH_ENV"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that there will be some conflicts between this PR and #5451 @aweng98

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I'll also consult @aweng98 before merging this branch. Thank you @calbach!

e2e/.env.sample
READER_USER=??
COLLABORATOR_USER=??
ACCESS_TEST_USER=??
ADMIN_TEST_USER=??
Copy link
Contributor

@calbach calbach Aug 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I am pretty lazy about creating local accounts, especially as each one requires upkeep. How many of these are necessary to run the standard puppeteer test suite, and how many of these can overlap? FOr the existing ones, that may be an @aweng98 question. It may be worth updating the README to explain how many users someone is expected to create locally.

For example: can ADMIN_TEST_USER == USER_NAME locally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chavanr2019 ^

aweng98
aweng98 suggested changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@aweng98 aweng98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Missing one update here in package.json.

@chavanr2019 chavanr2019 changed the title [risk=no][RW-4273]Add admin_test_user to e2e config,yarn,readme,env [risk=no][RW-7215]Add admin_test_user to e2e config,yarn,readme,env Aug 24, 2021
@chavanr2019 chavanr2019 merged commit fe57607 into master Aug 24, 2021
@chavanr2019 chavanr2019 deleted the chavanr/admin-test-account-1 branch August 24, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthibault79 jmthibault79 Awaiting requested review from jmthibault79

2 more reviewers

@calbach calbach calbach approved these changes

@aweng98 aweng98 aweng98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chavanr2019 @calbach @aweng98