Skip to content

当zk出现session time out可能会导致instance出现多个消费者，从而出现乱序，数据丢失 #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024
Merged

当zk出现session time out可能会导致instance出现多个消费者，从而出现乱序，数据丢失 #5270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server/src/main/java/com/alibaba/otter/canal/server/CanalMQStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.slf4j.MDC;

import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
Expand Down Expand Up @@ -106,7 +107,10 @@ public synchronized void destroy() {

public synchronized void startDestination(String destination) {
CanalInstance canalInstance = canalServer.getCanalInstances().get(destination);
if (canalInstance != null) {
CanalMQRunnable canalMQRunable = canalMQWorks.get(destination);
//当zk出现session time out可能会导致instance出现多个消费者，从而出现乱序
//因此当抢占成功的实例已经启动CanalMQRunnable时就不需要stop然后start了
if (canalInstance != null && Objects.isNull(canalMQRunable)) {
stopDestination(destination);
CanalMQRunnable canalMQRunnable = new CanalMQRunnable(destination);
canalMQWorks.put(canalInstance.getDestination(), canalMQRunnable);
Expand Down