Fix source string exec #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
reviewed
Jul 19, 2021
birdseye/utils.py
Outdated
| '\n' if i < 2 and cookie_re.match(line) | ||
| else line | ||
| for i, line in enumerate(f) | ||
| line for line in linecache.cache[filename][2] |
There was a problem hiding this comment.
Needs to use linecache.getlines (not direct access to the cache) and needs to use it instead of opening the file (linecache will open the file if needed) but still checking cookie_re.
There was a problem hiding this comment.
OK. I hadn't realized that there was a getlines method as it's missing from the docs.
alexmojaki
reviewed
Jul 19, 2021
birdseye/utils.py
Outdated
| return ''.join([ | ||
| '\n' if i < 2 and cookie_re.match(line) | ||
| else line | ||
| for line in linecache.getlines(filename) |
|
I see the test failure, this actually makes me realise I need to take a different path to resolve this. So you don't need to try and fix this, I'll take care of it. |
|
Ended up not going with my original plan, but hey, this works. Thanks for your help! |
|
Released in 0.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.