Skip to content

Conversation

@aliel
Copy link
Member

@aliel aliel commented Sep 27, 2025

Add ipfs.pinning configuration section for separate pinning service with backward compatibility

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • [-] Are there enough tests
  • [-] Documentation has been included (for new feature)

How to test

ipfs:
  enabled: true
  host: ipfs      # P2P operations
  port: 5001
  pinning:
    host: "ipfs-pinning-service" # Different host for pinning
    port: 5001
    scheme: "http"
    timeout: 60

Notes

Experimental feature

@aliel aliel requested a review from nesitor September 27, 2025 10:46
@aliel aliel force-pushed the aliel-enh-ipfs-for-pinning branch 6 times, most recently from 9820158 to a930ac5 Compare September 30, 2025 08:32
nesitor
nesitor previously approved these changes Sep 30, 2025
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ith backward compatibility

refactor make_ipfs_client
@aliel aliel force-pushed the aliel-enh-ipfs-for-pinning branch from a930ac5 to 0ba9d9c Compare October 1, 2025 07:50
@aliel aliel requested a review from nesitor October 1, 2025 17:20
@aliel aliel merged commit 2acce93 into main Oct 2, 2025
5 checks passed
odesenfans added a commit that referenced this pull request Oct 29, 2025
The endpoint returned a 500 error code in all situations because of a
missing "Name" field in the response from the IPFS service
implementation. This regression was introduced in #859.

This commit gets the filename from the multipart upload or hardcodes it
to "file" otherwise.
odesenfans added a commit that referenced this pull request Oct 30, 2025
)

The endpoint returned a 500 error code in all situations because of a
missing "Name" field in the response from the IPFS service
implementation. This regression was introduced in #859.

This commit gets the filename from the multipart upload or hardcodes it
to "file" otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants