Skip to content

Fix: SDK error when retrieving fallback private key, but the symlink was dead. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Fix: SDK error when retrieving fallback private key, but the symlink was dead. #33

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be0588a
Fix: SDK error when retrieving fallback private key, but the symlink …
1yam Jul 5, 2023
f595de3
Fix : return private key
1yam Jul 5, 2023
4fd701a
Update src/aleph/sdk/chains/common.py
1yam Jul 5, 2023
fd78ec3
Update src/aleph/sdk/chains/common.py
1yam Jul 5, 2023
a418aaf
Fix: add logger warning
1yam Jul 6, 2023
76ce7f4
Fix: logger should be a warning and not debug
1yam Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/aleph/sdk/chains/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

from aleph.sdk.conf import settings

import logging

logger = logging.getLogger(__name__)

def get_verification_buffer(message: Dict) -> bytes:
"""
Expand Down Expand Up @@ -120,7 +123,13 @@ def get_fallback_private_key(path: Optional[Path] = None) -> bytes:
path.write_bytes(private_key)

default_key_path = path.parent / "default.key"

# If the symlink exists but does not point to a file, delete it.
if default_key_path.is_symlink() and not default_key_path.resolve().exists():
default_key_path.unlink()
logger.warning("The symlink to the private key is broken")

# Create a symlink to use this key by default
if not default_key_path.exists():
# Create a symlink to use this key by default
default_key_path.symlink_to(path)
return private_key