Skip to content

Record executions on all CRN #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 8, 2025
Merged

Record executions on all CRN #18

merged 27 commits into from
Oct 8, 2025

Conversation

@olethanh
Copy link
Contributor

@olethanh olethanh commented Aug 18, 2025 •
edited
Loading

Dev Run via

hatch run scoring record-executions  --log-level DEBUG --stdout

olethanh added 10 commits August 1, 2025 17:01
@olethanh
WIP Record executions on all CRN
08d4476 
Dev Run via
```
hatch run scoring record-executions  --log-level DEBUG --stdout
```

Warning WIP not finished. At the moment it only check a subset to be
faster but the main logic is there

TODO: Filter diagnostic vm
@olethanh
Executions: Ignore diagnostics VMs
70c77df
@olethanh
Execution proper schema
d9b1e0f
@olethanh
Remove leftover unused executions.asn module
970d045
@olethanh
fixup! Execution proper schema
a30a95b
@olethanh
Publish executions
d783b22
@olethanh
Remove debug mode
c5cb713
@olethanh
linting
317d41f
@olethanh
fix ci
de4a8d2
@olethanh
CI move to black
baa54f8
@olethanh olethanh changed the title WIP Record executions on all CRN Record executions on all CRN Sep 3, 2025
@olethanh olethanh marked this pull request as ready for review September 3, 2025 13:57
nesitor
nesitor reviewed Sep 9, 2025
View reviewed changes
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you modified things for testing and committed the changes without reverting them. Please review the PR again.

@nesitor
Copy link
Member

nesitor commented Sep 9, 2025

Also the PR don't pass the CI

@olethanh
Copy link
Contributor Author

olethanh commented Sep 10, 2025

Also the PR don't pass the CI

Actually the CI was not passing before already. Seem it got broken long before, I think by this commit in 2024 7491cf1
None of the test are passing as it refer old code.

@olethanh olethanh force-pushed the ol-record-executions branch from c8e9ae1 to bf74d29 Compare September 11, 2025 11:43
@olethanh
Copy link
Contributor Author

olethanh commented Sep 12, 2025

@nesitor I have fixed the CI (fixed the configuration , the linting and the errors)

@olethanh olethanh requested a review from nesitor September 12, 2025 07:36
nesitor
nesitor reviewed Sep 18, 2025
View reviewed changes
@olethanh olethanh force-pushed the ol-record-executions branch from e15d1b0 to f5682e7 Compare September 23, 2025 10:04
@olethanh olethanh force-pushed the ol-record-executions branch from f5682e7 to df7b213 Compare September 23, 2025 10:11
@nesitor nesitor merged commit 0c7a9d8 into dev Oct 8, 2025
1 check passed
@nesitor nesitor deleted the ol-record-executions branch October 8, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nesitor nesitor nesitor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olethanh @nesitor