feat: Allow configuring hooks via Kong's functional options #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Mar 20, 2025
options.go
Outdated
| }) | ||
| } | ||
|
|
||
| func BeforeApplyHook(fn hook) Option { |
Owner
There was a problem hiding this comment.
I was literally just wanting this functionality yesterday, so +1 from me.
I'd prefer this to be named WithBeforeApply, and fn will have to be any to correctly match any function.
Contributor
Author
There was a problem hiding this comment.
Done!
What do you think of removing https://github.com/alecthomas/kong/blob/master/hooks.go and naming these functional options BeforeReset, BeforeResolve, etc?
11f88bf to
ccac06b
Compare
Lets you pass `kong.WithBeforeApply` along with a function that supports dynamic bindings to register a `BeforeApply` hook without tying it directly to a node in the schema. Co-authored-by: Sutina Wipawiwat <[email protected]>
ccac06b to
afbf0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets you pass
kong.WithBeforeApplyalong with a function that supports dynamic bindings to register aBeforeApplyhook without tying it directly to a node in the schema.Also updates the README.md to list a table of hooks with their meanings.