feat: Support variable interpolation in vars #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
commented
Sep 20, 2025
| } | ||
|
|
||
| if value.Enum, err = interpolate(value.Enum, vars, nil); err != nil { | ||
| return fmt.Errorf("enum for %s: %s", value.Summary(), err) |
There was a problem hiding this comment.
This Enum interpolation was duplicated and run twice. I removed it. This is unrelated to this PR though.
mitar
added a commit
to charon/charon
that referenced
this pull request
Sep 21, 2025
|
Thanks for quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552.
It does it only one iteration, but I think this is enough. Maybe in the future (if somebody asks) we could do it in a loop until nothing is interpolated anymore. But I think this is fine for now.