Skip to content

build: add version to release filename. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

build: add version to release filename. #138

merged 1 commit into from
Aug 16, 2023

Conversation

@winder
Copy link
Contributor

@winder winder commented Aug 16, 2023

Summary

Add the version to release filenames to be closer to the pattern used by algod.

conduit_Darwin_all_1.3.1.tar.gz
conduit_Linux_arm64_1.3.1.tar.gz
conduit_Linux_x86_64_1.3.1.tar.gz
conduit_Windows_arm64_1.3.1.tar.gz
conduit_Windows_x86_64_1.3.1.tar.gz

Test Plan

Run goreleaser locally.

@winder winder requested review from a team, algobarb and excalq August 16, 2023 13:53
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #138 (ebfc1bf) into master (442791a) will increase coverage by 2.86%.
Report is 51 commits behind head on master.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   67.66%   70.53%   +2.86%     
==========================================
  Files          32       36       +4     
  Lines        1976     2545     +569     
==========================================
+ Hits         1337     1795     +458     
- Misses        570      653      +83     
- Partials       69       97      +28
Files Changed Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/metadata.go 69.11% <ø> (ø)
conduit/plugins/config.go 100.00% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) ⬇️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...gins/processors/filterprocessor/fields/searcher.go 77.50% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) ⬆️
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) ⬆️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder merged commit 1816271 into algorand:master Aug 16, 2023
@winder winder deleted the will/version-in-filename branch August 16, 2023 14:11
tzaffi pushed a commit to tzaffi/conduit that referenced this pull request Aug 21, 2023
@winder
build: add version to release filename. (algorand#138)
136996b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@excalq excalq Awaiting requested review from excalq excalq was automatically assigned from algorand/devops

1 more reviewer

@algobarb algobarb algobarb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winder @algobarb