Skip to content

Define and update e2e file in Makefile. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2023
Merged

Define and update e2e file in Makefile. #110

merged 1 commit into from
Jun 23, 2023

Conversation

@winder
Copy link
Contributor

@winder winder commented Jun 23, 2023 •
edited
Loading

Summary

Moves the CI_E2E_FILENAME definition into the Makefile so that make e2e-conduit is easier to run locally.

This PR also pins the filename to a more recent version.

The variable is defined with ?= to allow it to be overridden by an environment variable.

Test Plan

Existing CI.

@winder winder self-assigned this Jun 23, 2023
@winder winder requested a review from a team June 23, 2023 12:55
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #110 (1154e41) into master (442791a) will increase coverage by 2.64%.
The diff coverage is 75.84%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   67.66%   70.30%   +2.64%     
==========================================
  Files          32       37       +5     
  Lines        1976     2512     +536     
==========================================
+ Hits         1337     1766     +429     
- Misses        570      651      +81     
- Partials       69       95      +26
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) ⬇️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) ⬆️
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) ⬆️
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 65.68% <51.21%> (-12.52%) ⬇️
pkg/cli/cli.go 65.97% <65.97%> (ø)
... and 12 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algochoi
algochoi approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the E2E tests work on my machine after this PR!

@winder winder merged commit 7dafc16 into algorand:master Jun 23, 2023
@winder winder deleted the will/fix-make-e2e branch June 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@algochoi algochoi algochoi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@winder winder

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winder @algochoi