enhancement: disallow Register() name dupes #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 67.66% 68.58% +0.92%
==========================================
Files 32 36 +4
Lines 1976 2394 +418
==========================================
+ Hits 1337 1642 +305
- Misses 570 660 +90
- Partials 69 92 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
May 8, 2023
winder
approved these changes
May 8, 2023
|
Good idea, nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposing that when
Register()is called twice for the same plugin name, it will panic.An alternative would involve changing the signature to return an
error.Explanation
This is mostly about familiarizing myself with the Conduit repo. This is not an urgent issue.
As I was playing around with conduit plugin templates I realized there is a slight issue with plugin registration.
The current functionality keeps a map from a user provided name to the actual plugin. If a plugin with the same name as another is registed a second time, it simply overwrites the first. This certainly isn't a pressing concern as we have complete control over what to register and what not to.
Test Plan
CI