Type stubs #4
Merged
Type stubs #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces type stubs and adjusts function return types in the storage module, along with adding tests to cover irregular types.
- Updated test cases in tests/test_talsi.py to include a new scenario for irregular types.
- Revised function signatures in src/storage.rs (including ensure_namespace_table and internal_insert) to return counts instead of unit values.
- Minor import statement adjustments in src/typ.rs and type stubs added in python/talsi/_talsi.pyi to support the new return types and type definitions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_talsi.py | Added tests for irregular types and a TODO comment regarding generator support. |
| src/typ.rs | Adjusted the ordering of imports for consistency. |
| src/storage.rs | Updated function signatures and return types from unit to usize in key methods. |
| python/talsi/_talsi.pyi | Added type stubs corresponding to the public API changes, ensuring alignment with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.