Skip to content

fix(ui): popover visibility #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2019
Merged

fix(ui): popover visibility #314

merged 2 commits into from
Mar 18, 2019

Conversation

artyorsh
Copy link
Collaborator

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • Removes useless render of popover while it is invisible
  • Refactors components built on Popover

@artyorsh artyorsh added needs review 📱 Components components module-specific ➡️ Next Upcoming changes labels Mar 18, 2019
@artyorsh artyorsh self-assigned this Mar 18, 2019
@artyorsh artyorsh requested a review from 32penkin March 18, 2019 11:24
@artyorsh artyorsh merged commit 903f766 into next Mar 18, 2019
@artyorsh artyorsh deleted the fix/popover-visibility branch March 18, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@32penkin 32penkin 32penkin approved these changes

Assignees

@artyorsh artyorsh

Labels

➡️ Next Upcoming changes 📱 Components components module-specific

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artyorsh @32penkin