fix(ui): modal component/service/panel, popover fix. Closes #269 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

32penkin merged 9 commits into next from fix/modal-closing

Mar 7, 2019

Member

32penkin commented Mar 5, 2019

Please read and mark the following check list before creating a pull request:

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

32penkin added 7 commits

March 1, 2019 19:33


          refactor(ui): modal service/panel/component refactor

2eeddff


          refactor(ui): modal service/panel/component refactor

473d7d0


          refactor(test): modal service/panel/component tests refactor

a13c099


          fix(ui): popover self-placement fix

7aa5bca


          fix(ui): popover self-placement fix

884f7a1


          Merge branch 'next' into fix/modal-closing

47e64c3


          teat(ui): modal tests update

32penkin added needs review 📱 Components ➡️ Next labels

32penkin self-assigned this

32penkin requested review from artyorsh and malashkevich

March 5, 2019 13:27

artyorsh reviewed

View reviewed changes

src/framework/theme/component/modal/modalPanel.component.tsx Outdated Show resolved Hide resolved

artyorsh reviewed

View reviewed changes

src/framework/theme/component/modal/modalPanel.component.tsx Outdated Show resolved Hide resolved

artyorsh reviewed

View reviewed changes

src/framework/theme/component/modal/modalPanel.spec.tsx Outdated Show resolved Hide resolved

artyorsh reviewed

View reviewed changes

src/framework/theme/component/modal/modalPanel.spec.tsx Outdated Show resolved Hide resolved

artyorsh reviewed

View reviewed changes

src/playground/src/ui/screen/popover.component.tsx Show resolved Hide resolved

artyorsh suggested changes

View reviewed changes

Collaborator

artyorsh left a comment

Looks good but code style changes are needed

artyorsh changed the title ~~fix(ui): modal component/service/panel, popover fix~~ fix(ui): modal component/service/panel, popover fix. Closes #269

malashkevich reviewed

View reviewed changes

src/framework/ui/popover/popover.component.tsx Show resolved Hide resolved

malashkevich approved these changes

View reviewed changes

32penkin added 2 commits

March 7, 2019 13:12


          Merge branch 'next' into fix/modal-closing

297887c


          refactor(ui): code style refactor

e86741e

artyorsh approved these changes

View reviewed changes

32penkin merged commit a0491cb into next

32penkin deleted the fix/modal-closing branch

March 7, 2019 13:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

➡️ Next 📱 Components