Skip to content

refactor(framework): apply code style and token-groups #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 20, 2019
Merged

refactor(framework): apply code style and token-groups #247

merged 18 commits into from
Feb 20, 2019

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Jan 26, 2019 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • applies conventional code style to ui module components
  • applies typescript usage to theme module components

@artyorsh artyorsh added needs review 📱 Components components module-specific labels Jan 26, 2019
@artyorsh
Copy link
Collaborator Author

artyorsh commented Feb 8, 2019 •
edited
Loading

Used this pr to integrate components with token-group mappings

For components that are not currently merged we can do this in future, after integrated code is merged (this is mostly actual for #254 #262 #263)

@artyorsh artyorsh changed the title refactor(framework): apply conventional code style refactor(framework): code style and token-groups Feb 8, 2019
@artyorsh artyorsh changed the title refactor(framework): code style and token-groups refactor(framework): apply code style and token-groups Feb 8, 2019
@artyorsh artyorsh mentioned this pull request Feb 8, 2019
Closed
malashkevich
malashkevich reviewed Feb 11, 2019
View reviewed changes
malashkevich
malashkevich reviewed Feb 11, 2019
View reviewed changes
malashkevich
malashkevich reviewed Feb 11, 2019
View reviewed changes
@artyorsh artyorsh merged commit b5d8ce6 into next Feb 20, 2019
@artyorsh artyorsh deleted the refactor/framework branch February 20, 2019 15:43
@artyorsh artyorsh self-assigned this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malashkevich malashkevich malashkevich approved these changes

@32penkin 32penkin 32penkin approved these changes

Assignees

@artyorsh artyorsh

Labels

📱 Components components module-specific

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artyorsh @malashkevich @32penkin