Modal/Popover update - migrate Modal/Popover to the RN's Modal #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed on Popover (tooltip, select, overflowMenu, datepicker, autocomplete)
|
Try running it with Kitten Tricks |
|
Try running it with Kitten Tricks |
malashkevich
reviewed
May 2, 2022
| * }; | ||
| * ``` | ||
| */ | ||
| class ModalServiceType { |
There was a problem hiding this comment.
Do we need this one as we are using react-native Modal?
malashkevich
reviewed
May 2, 2022
| visible?: boolean; | ||
| shouldUseContainer?: boolean; | ||
| children?: React.ReactNode; | ||
| animationType?: 'none' | 'slide' | 'fade'; |
malashkevich
reviewed
May 2, 2022
| animationType?: 'none' | 'slide' | 'fade'; | ||
| onShow?: (event: NativeSyntheticEvent<any>) => void; | ||
| supportedOrientations?: Array< | ||
| 'portrait' | 'portrait-upside-down' | 'landscape' | 'landscape-left' | 'landscape-right' |
malashkevich
reviewed
May 2, 2022
| type PopoverModalProps = Overwrite<ModalProps, { | ||
| children?: React.ReactElement; | ||
| }>; | ||
| }> & Pick<ModalProps, 'animationType' | 'hardwareAccelerated' | 'supportedOrientations' | 'onShow'>; |
malashkevich
reviewed
May 2, 2022
| return fitsBottom(frame, other) && fitsLeft(frame, other) && fitsRight(frame, other); | ||
| } | ||
| }; | ||
| static INNER: PopoverPlacement = new class implements PopoverPlacement { |
There was a problem hiding this comment.
It does makes sense to split this file into multiple
malashkevich
approved these changes
May 2, 2022
|
Try running it with Kitten Tricks |
flexbox
reviewed
May 19, 2022
| import { ThemeProviderProps } from '../theme/themeProvider.component'; | ||
| import { ModalPanel } from '../modal/modalPanel.component'; | ||
| // import { ModalPanel } from '../modal/modalPanel.component'; |
There was a problem hiding this comment.
I don't this you want to leave this comment here :)
greenfrvr
reviewed
Oct 21, 2022
# Conflicts: # src/components/ui/menu/menuGroup.component.tsx
|
Try running it with Kitten Tricks |
# Conflicts: # package.json # src/components/devsupport/components/measure/measure.component.tsx # src/components/theme/application/applicationProvider.component.tsx # src/components/theme/modal/modal.service.tsx # src/components/theme/modal/modal.spec.tsx # src/components/theme/modal/modalPanel.component.tsx # src/components/ui/autocomplete/autocomplete.component.tsx # src/components/ui/autocomplete/autocomplete.spec.tsx # src/components/ui/datepicker/datepicker.spec.tsx # src/components/ui/datepicker/rangeDatepicker.spec.tsx # src/components/ui/menu/menuGroup.component.tsx # src/components/ui/modal/modal.component.tsx # src/components/ui/modal/modal.spec.tsx # src/components/ui/overflowMenu/overflowMenu.component.tsx # src/components/ui/popover/popover.component.tsx # src/components/ui/popover/popover.spec.tsx # src/components/ui/select/select.spec.tsx # src/components/ui/tab/tab.spec.tsx # src/components/ui/tooltip/tooltip.component.tsx # yarn.lock
…rlays-update # Conflicts: # src/components/ui/tab/tab.spec.tsx
Closed
| > | ||
| {this.props.anchor()} | ||
| </MeasureElement> | ||
| <View> |
There was a problem hiding this comment.
Why did you add this View component. It adds additional wrapper which broke some ui.
There was a problem hiding this comment.
@sayres @malashkevich please check my comment
There was a problem hiding this comment.
maybe there is should be Fragment ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Modal and Popover components moved to RN's Modal component implementation