Skip to content

fix: menu onPress event for groups & items #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 5, 2021
Merged

fix: menu onPress event for groups & items #1339

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
30dfa18
fix: menu onPress event for groups & items
Jan 28, 2021
49e1e5b
fix: clone onPress with one call
Feb 2, 2021
1b67fa6
fix: remove dead code
Feb 7, 2021
30eb1b4
Merge branch 'master' into fix/menuGroup
malashkevich Feb 9, 2021
72a35af
fix(menu): update logic when multiple onPress events passed
Feb 27, 2021
b920de7
fix(menu): remove useless onPress from menu press event
Mar 2, 2021
224592b
fix(menu): structure onPress event
Mar 3, 2021
31027ab
fix: remove dead code
Mar 3, 2021
1d33634
feat(menu): onSelect calls by selecting group, updating tests
Mar 3, 2021
4eafa83
update(menu): separate tests
Mar 4, 2021
2ed391b
Merge branch 'master' into fix/menuGroup
malashkevich Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove dead code
  • Loading branch information
Ivan Vezhnavets authored and Ivan Vezhnavets committed Feb 7, 2021
commit 1b67fa6c23dc7075713e2e440aa037393e4b0091
1 change: 0 additions & 1 deletion src/components/ui/menu/menu.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export class Menu extends React.Component<MenuProps> {
};

private onItemPress = (descriptor: MenuItemDescriptor): void => {
console.log('press');
this.props.onSelect && this.props.onSelect(descriptor.index);
};

Expand Down