-
Notifications
You must be signed in to change notification settings - Fork 977
fix(ui): add rtl fixes and demo #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks. As I've mentioned in #559, I'm going to review this soon and show you an idea of how we can do this better. I'll create a few patches soon. Let's keep in touch in this conversation |
checkbox can be better ... I changed the left and right and then rotate 180 degree! it's wrong but I couldn't find out the pattern.. |
src/framework/ui/support/components/checkmark/checkmark.component.tsx
Outdated
Show resolved
Hide resolved
@sijav done. Actually, the code I've pushed is my vision of how this should work. This does 3 things:
I've also refactored the Button you've placed into a Home Screen to a component preview screen |
This is perfect |
This bug only exists where the index is at 0 and user pan to index 1 but change it's mind and pan to oposite of the screen, then the view pager would select the -1 index which does not exist and is wrong. same happens with pan from last element as well
…of boundry" This reverts commit 6d3e76d.
Great work :) any ETA ? |
@592da This will be included in v4.2. Actually, we don't have any ETAs, but I guess it will be landed at the end of August. |
@sijav 🎉 |
thanks for your work :) |
Short description of what this resolves: this will add RTL demo in playground and fix RTL problems. the fixes includes: