Skip to content

Conversation

sijav
Copy link
Contributor

@sijav sijav commented Aug 1, 2019

Short description of what this resolves: this will add RTL demo in playground and fix RTL problems. the fixes includes:

  • some text align left in playground fix label and section label
  • add RTL/LTR button in playground's header
  • fix checkmark
  • fix input description and label text align
  • fix list title and description text align
  • fix toggle animation
  • fix tab indicator animation and index (this fixes the bottom navigation tab indicator)
  • fix view pager user interaction (this fixes the tab view)

@artyorsh artyorsh self-requested a review August 1, 2019 09:23
@artyorsh artyorsh added 📱 Components components module-specific needs review labels Aug 1, 2019
@artyorsh
Copy link
Collaborator

artyorsh commented Aug 1, 2019

Thanks. As I've mentioned in #559, I'm going to review this soon and show you an idea of how we can do this better. I'll create a few patches soon. Let's keep in touch in this conversation

@sijav
Copy link
Contributor Author

sijav commented Aug 1, 2019

checkbox can be better ... I changed the left and right and then rotate 180 degree! it's wrong but I couldn't find out the pattern..
and popover x position is wrong I'll work on it later

@artyorsh
Copy link
Collaborator

artyorsh commented Aug 1, 2019

@sijav done. Actually, the code I've pushed is my vision of how this should work.
The idea is to encapsulate I18nManager calls to a framework service (I've called it I18nLayoutService)

This does 3 things:

  • isRTL - check if the layout currently in RTL mode
  • select - returns a value depending on current layout direction
  • toI18nStyle - ignores RTL mode. AFAIK React Native replaces flex styles to opposite depending on RTL is enabled. This function forces it back. This is how CheckMark and other things could be simplified :)

I've also refactored the Button you've placed into a Home Screen to a component preview screen

artyorsh
artyorsh previously approved these changes Aug 1, 2019
@sijav
Copy link
Contributor Author

sijav commented Aug 1, 2019

This is perfect

This bug only exists where the index is at 0 and user pan to index 1 but change it's mind and pan to oposite of the screen, then the view pager would select the -1 index which does not exist and is wrong.
same happens with pan from last element as well
32penkin
32penkin previously approved these changes Aug 2, 2019
@592da
Copy link

592da commented Aug 18, 2019

Great work :) any ETA ?

@artyorsh
Copy link
Collaborator

@592da This will be included in v4.2. Actually, we don't have any ETAs, but I guess it will be landed at the end of August.

@artyorsh artyorsh merged commit 14bf854 into akveo:master Aug 19, 2019
@artyorsh
Copy link
Collaborator

@sijav 🎉

@592da
Copy link

592da commented Sep 2, 2019

tabview and buttongroup still broken for me,
using master

thanks for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Components components module-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants