Skip to content

Conversation

@gwer
Copy link
Contributor

@gwer gwer commented Oct 30, 2018

Remove bitshifting hack.
Remove variables reuse.
Use [].slice for Object.prototype properties collision fix.

@ai
Copy link
Owner

ai commented Oct 30, 2018

Can you run ./test/benchmark on Node 11 before and after this fix?

I tried this way before, but on old Node.js found big reducing in performance.

@gwer
Copy link
Contributor Author

gwer commented Oct 30, 2018

Are you sure ./test/benchmark should exist?

@ai
Copy link
Owner

ai commented Oct 30, 2018

Oops, it is a wrong nano* project :D

I thought I was in Nano ID

@ai ai merged commit cd2f9c1 into ai:master Oct 30, 2018
@ai
Copy link
Owner

ai commented Oct 30, 2018

Thanks. Released in 1.0.8.

@StreetStrider
Copy link

That was a beautiful in-place hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants