Skip to content

Conversation

@kroggen
Copy link
Member

@kroggen kroggen commented Nov 9, 2023

When the title or the first comment of a PR is edited, a new CI/CD workflow run is activated

This is annoying, uses CI time without need, and marks some PRs as failing when the run is cancelled

This PR disable this behavior

When the base of a PR is modified, then we need to start a new run manually, until GitHub has a solution for the problem

@kroggen kroggen requested review from gosunuts and hayarobi November 9, 2023 16:37
@gosunuts
Copy link
Member

What do you think about remove verbose option when go tests? Verbose test is confusing and make hard to find error line.

@kroggen
Copy link
Member Author

kroggen commented Nov 10, 2023

I agree

@kroggen
Copy link
Member Author

kroggen commented Nov 13, 2023

@hayarobi
Do you agree?
Should the verboseness be removed also from the "code coverage" test?

@kroggen kroggen force-pushed the topic/disable-ci-run-on-pr-edit branch from ba2ae22 to d3a2764 Compare November 13, 2023 03:48
Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kroggen kroggen merged commit 43b5927 into develop Nov 13, 2023
@kroggen kroggen deleted the topic/disable-ci-run-on-pr-edit branch November 13, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants