refactoring for fee calc logic #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO : make unit tests for fee / gas functions
tx total fee = base fee + execute fee
kroggen
reviewed
Nov 6, 2023
kroggen
reviewed
Nov 6, 2023
kroggen
reviewed
Nov 7, 2023
|
Why the sync test was started before the review? It is not approved |
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
it is my mistake. ( communicate with kyungsub ) i will start sync test after approved. |
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
reviewed
Nov 7, 2023
kroggen
approved these changes
Nov 7, 2023
|
start sync mainnet |
|
sync success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed?
refactoring fee calculation logic to fee package
add unit tests for fee logic
( tx total fee = tx base fee + tx execute fee )
Is there risk of fork?
yes. it need to sync test.