Skip to content

Fix/unittest pr418 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2025
Merged

Fix/unittest pr418 #423

merged 2 commits into from
Jul 27, 2025

Conversation

@hayarobi
Copy link
Member

This will fix compile error and failures while running unit test.

@hayarobi hayarobi requested a review from kroggen July 26, 2025 15:52
kroggen
kroggen approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@kroggen kroggen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be merged because it does not affect the RPC
It worked with herajs

@hayarobi hayarobi merged commit 51fc103 into develop Jul 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroggen kroggen kroggen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hayarobi @kroggen