Skip to content

Conversation

@kroggen
Copy link
Member

@kroggen kroggen commented Jul 23, 2025

This PR reverts 3 commits causing problems with RPC:

#409 Add more RPC input parameter checks
#417 Improved validation of input argument
#418 Fix sync fails on speicfic situation

@kroggen kroggen requested a review from hayarobi July 23, 2025 22:10
@hayarobi
Copy link
Member

#418 is not related to RPC actually, but cause test fails. I made patches to fix for both RPC and P2P test failure cases separately.
We have several choices; the one is merge this PR and re-apply my PR that contains the reverted commits and fix commits. The other is merging fix PR first and then merge this PR with deleting revert commits.

@kroggen
Copy link
Member Author

kroggen commented Jul 26, 2025

Merge #421 either into develop or onto your new branch, to make sure they pass the new tests

Then test locally with herajs by running a local mode in --testmode (use enablebp=1 on the config)

@kroggen kroggen mentioned this pull request Jul 26, 2025
@kroggen
Copy link
Member Author

kroggen commented Jul 26, 2025

You can also cherry-pick the last 2 commits from this into your PR

But merging #421 is required as well, then rebase your branch. Or cherry-pick the commits from there

Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll modify the #421 to follow this PR.

@hayarobi hayarobi merged commit 55c64db into develop Jul 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants