Fix rounding in otfautohint #1759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple fix for rounding stem locations in otfautohint. I didn't really add new tests, but @punchcutter and I updated some existing tests with new output, some of which demonstrate the rounding.
This problem crept in because the old and new code have difference sources of stem "locations", particularly when it comes to inflection points and spline extrema. So while most of the rounding was handled by having round spline endpoint locations, some of it wasn't. This PR adds rounding at the point where "segments" (which are used down-stream to choose stem locations) are added.
Simply rounding BlueValue locations like this wouldn't work because stems have to be within a blue zone to be affected by one, as I learned with the more recent FreeType fix. But with stems it seems to be a matter of just being near enough to one side (which makes conceptual sense). So I think we should integrate this and then do basic verification using Momochidori.
Checklist: