Collect metrics for a set of CG states #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
reviewed
Jul 18, 2023
amuraru
reviewed
Jul 18, 2023
minion/consumer_group_offsets.go
Outdated
| if len(s.Cfg.ConsumerGroups.ConsumerGroupStates) == 0 { | ||
| groupIDs[i] = group.Group | ||
| } else { | ||
| for _, state := range s.Cfg.ConsumerGroups.ConsumerGroupStates { |
There was a problem hiding this comment.
instead of iterating through all states can we keep these states in a map and do a O(1) lookup here?
Co-authored-by: Adrian Muraru <[email protected]>
amuraru
reviewed
Jul 19, 2023
amuraru
reviewed
Jul 19, 2023
minion/consumer_group_offsets.go
Outdated
Comment on lines
26
to
30
| // create a map for faster lookup | ||
| groupStatesMap := make(map[string]string, len(s.Cfg.ConsumerGroups.AllowedConsumerGroupStates)) | ||
| for _, state := range s.Cfg.ConsumerGroups.AllowedConsumerGroupStates { | ||
| groupStatesMap[state] = state | ||
| } |
There was a problem hiding this comment.
move this to minion/config_consumer_group.go
amuraru
approved these changes
Jul 19, 2023
06bc6e9 to
11eedc3
Compare
amuraru
added a commit
that referenced
this pull request
Sep 13, 2025
* Filter empty consumer groups * Collect metrics for a set of CG states * Update minion/config_consumer_group.go Co-authored-by: Adrian Muraru <[email protected]> * Implement review * Implement review * Update the CG state values --------- Co-authored-by: Adrian Muraru <[email protected]>
amuraru
added a commit
that referenced
this pull request
Oct 15, 2025
* Filter empty consumer groups * Collect metrics for a set of CG states * Update minion/config_consumer_group.go Co-authored-by: Adrian Muraru <[email protected]> * Implement review * Implement review * Update the CG state values --------- Co-authored-by: Adrian Muraru <[email protected]>
amuraru
added a commit
that referenced
this pull request
Oct 16, 2025
* Filter empty consumer groups * Collect metrics for a set of CG states * Update minion/config_consumer_group.go Co-authored-by: Adrian Muraru <[email protected]> * Implement review * Implement review * Update the CG state values --------- Co-authored-by: Adrian Muraru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the flexibility to collect metrics for CG that are in specific states. This allows for less metrics when users create CGs each time the application starts.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: