Skip to content

update @adobe/eslint-config-aio-lib-config and its peer dependencies. fix for node-16 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2021
Merged

update @adobe/eslint-config-aio-lib-config and its peer dependencies. fix for node-16 #102

merged 2 commits into from
Dec 9, 2021

Conversation

@shazron
Copy link
Member

@shazron shazron commented Dec 9, 2021 •
edited
Loading

Fixes daily.yml Github Action failure under node-16.

How Has This Been Tested?

  1. nvm use 16
  2. rm -rf node_modules
  3. rm package-lock.json
  4. npm i --package-lock --package-lock-only
  5. npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #102 (a2ebd66) into master (edf61e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          557       557           
  Branches        98        98           
=========================================
  Hits           557       557
Impacted Files Coverage Δ
lib/init.js 100.00% <ø> (ø)
lib/Files.js 100.00% <100.00%> (ø)
lib/impl/AzureBlobFiles.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf61e0...a2ebd66. Read the comment docs.

sandeep-paliwal
sandeep-paliwal approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit b83a7c8 into master Dec 9, 2021
@shazron shazron deleted the eslint-config-fix branch December 9, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeep-paliwal sandeep-paliwal sandeep-paliwal approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@Himavanth Himavanth Awaiting requested review from Himavanth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shazron @sandeep-paliwal