Skip to content

bug: list and getFileInfo inconsistent #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

bug: list and getFileInfo inconsistent #91

merged 1 commit into from
Mar 24, 2021

Conversation

@purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Mar 24, 2021 •
edited
Loading

these 2 calls should return the same shape of object, added internalUrl to list method results

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage
bug: list and getFileInfo inconsistent
2bc5961 
these 2 calls should return the same shape of object, added `internalUrl` to list method results
@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited
Loading

Codecov Report

Merging #91 (7f51ed2) into master (93290c8) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f51ed2 differs from pull request most recent head 2bc5961. Consider uploading reports for the commit 2bc5961 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          542       542           
  Branches        94        94           
=========================================
  Hits           542       542
Impacted Files Coverage Δ
lib/impl/AzureBlobFiles.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93290c8...2bc5961. Read the comment docs.

@purplecabbage purplecabbage merged commit 1d13e10 into master Mar 24, 2021
@purplecabbage purplecabbage deleted the purplecabbage-patch-1 branch March 24, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@purplecabbage