Updated locale method to use default locale when none is provided #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR changes the behavior of the |
|
Hello @thetutlage, Currently, to use i18n, we need to do something like: const i18n = i18nManager.locale(i18nManager.defaultLocale)
const subject = i18n.t('messages.email_confirmation_subject')I think Another suggestion is to provide a simpler way to use const { t } = i18nManager.default()
const subject = t('messages.email_confirmation_subject') |
|
Alright, makes sense! |
thetutlage
pushed a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
This change modifies the locale method to provide a default locale if none is specified. Previously, if the locale parameter was omitted, it would result in an undefined value being passed to the I18n instance. By using locale || this.defaultLocale, we ensure that the default locale is used, improving usability.
📝 Checklist