Skip to content

Use cache in check-dist.yml #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jongwooo wants to merge 1 commit into from
Closed

Use cache in check-dist.yml #369

jongwooo wants to merge 1 commit into from

Conversation

@jongwooo
Copy link

@jongwooo jongwooo commented Dec 6, 2022

Signed-off-by: jongwooo [email protected]

Description

Use cache in check-dist.yml
See actions/cache#1004

AS-IS

- name: Set Node.js 12.x
  uses: actions/setup-node@v1
  with:
    node-version: 12.x

TO-BE

- name: Set Node.js 12.x
  uses: actions/setup-node@v3
  with:
    node-version: 12.x
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

@jongwooo jongwooo requested a review from a team as a code owner December 6, 2022 16:10
@konradpabjan
Copy link
Contributor

konradpabjan commented Jan 5, 2023

Thanks for the PR but we've recently added caching in a separate PR while me migrated to node 16 so these changes are no longer needed

upload-artifact/.github/workflows/check-dist.yml

Lines 25 to 29 in 013d2b8

- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16.x
cache: 'npm'

@jongwooo jongwooo deleted the chore/use-cache-in-check-dist branch January 5, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jongwooo @konradpabjan