Skip to content

Adjust positioning of user email note and permissions heading #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benwells merged 1 commit into from
Jan 16, 2025
Merged

Adjust positioning of user email note and permissions heading #2044

benwells merged 1 commit into from
Jan 16, 2025
+3 −4

Conversation

@joshmgross
Copy link
Contributor

@joshmgross joshmgross commented Jan 16, 2025

The note about the user email should be in the section above this permissions section. Additionally this is all under the "Usage" top-level heading, but "Recommended permissions" isn't directly a usage scenario.

@joshmgross joshmgross requested a review from a team as a code owner January 16, 2025 20:42
@benwells benwells merged commit 85e6279 into main Jan 16, 2025
11 checks passed
@benwells benwells deleted the joshmgross/README-updates branch January 16, 2025 20:56
@phamhieu1919
Copy link

phamhieu1919 commented Jan 28, 2025

The note about the user email should be in the section above this permissions section. Additionally this is all under the "Usage" top-level heading, but "Recommended permissions" isn't directly a usage scenario.

peter10012 pushed a commit to xxmime/checkout that referenced this pull request Feb 8, 2025
@joshmgross @dkmos2016
Adjust positioning of user email note and permissions heading (action…
7713478 
…s#2044)
dataway added a commit to dataway/checkout-dw that referenced this pull request Mar 6, 2025
@dataway
Revert "Adjust positioning of user email note and permissions heading (…
7aeaf66 
…actions#2044)"

This reverts commit 85e6279.
rostomandjj added a commit to rostomandjj/checkout that referenced this pull request Apr 1, 2025
@rostomandjj
Adjust positioning of user email note and permissions heading (action…
dba7a82 
…s#2044)
ghost
ghost reviewed Apr 9, 2025
View reviewed changes
README.md
Copy link

@ghost ghost Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2044 (comment)