Skip to content

Conversation

@joshmgross
Copy link
Contributor

With #68, unsupported event types throw errors instead of failing during save. This breaks multi-event workflows that use the cache (such as a workflow that runs on schedules and push), as the scheduled build will now break due to the cache step failing.

While an if statement could be used, requiring that for a common workflow scenario can get verbose, especially as more events are added.

Example using if:

   - name: My Cache
      if: github.event_name == 'push' || github.event_name == 'pull_request'
      uses: actions/cache@v1
      with:
        path: .github
        key: ${{ runner.os }}-github

This PR changes the validation error into a warning and returns early.

Also updated to prefix warnings with a [warning] and log them normally, which will allow the highlighting in the logs without creating annotations.
Example using the [warning] prefix:
Screen Shot 2019-11-20 at 1 27 21 PM

@joshmgross joshmgross merged commit 95c1798 into master Nov 21, 2019
@joshmgross joshmgross deleted the joshmgross/warnings-update branch November 21, 2019 19:37
@whiskeysierra
Copy link

Will this be released soon?

@joshmgross
Copy link
Contributor Author

@whiskeysierra yep!

@whiskeysierra
Copy link

Great to hear! Will you also update v1 to the latest version?

@joshmgross
Copy link
Contributor Author

@whiskeysierra Yep!

We're following the Action Versioning Guidelines, so each new release will be an individual tag (like v1.0.3) and after final verification, the v1 tag is pushed to match the latest release. They're both out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants