Skip to content

Release support for cross-os caching as opt-in feature #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2023
Merged

Release support for cross-os caching as opt-in feature #1060

merged 4 commits into from
Jan 9, 2023

Conversation

Phantsure
Copy link
Contributor

Add documentation for cross-os caching

Description

Make new release for support of cross-os caching as opt-in feature and add documentation around cross-os caching.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Phantsure
Release support for cross-os caching as opt-in feature
192d0bc 
Add documentation for cross-os caching
@github-actions github-actions bot requested a review from vsvipul January 6, 2023 09:51
lvpx
lvpx reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@lvpx lvpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@actions actions deleted a comment from Aiasp1985P Jan 6, 2023
@actions actions deleted a comment from Aiasp1985P Jan 6, 2023
@Phantsure Phantsure marked this pull request as ready for review January 6, 2023 10:47
@Phantsure Phantsure requested a review from a team as a code owner January 6, 2023 10:47
@Phantsure Phantsure removed the request for review from vsvipul January 6, 2023 10:47
lvpx
lvpx approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@lvpx lvpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment.

@Phantsure Phantsure merged commit 58c146c into main Jan 9, 2023
@maybeec maybeec mentioned this pull request Jan 9, 2023
Closed
@mikelane mikelane mentioned this pull request Jan 10, 2023
Merged
@renovate renovate bot mentioned this pull request Feb 28, 2023
Merged
1 task
Dakshjain1 pushed a commit to SvavaCapital/cache that referenced this pull request Apr 19, 2024
@Phantsure @lvpx @Dakshjain1
Release support for cross-os caching as opt-in feature (actions#1060)
1244b1e 
* Release support for cross-os caching as opt-in feature
Add documentation for cross-os caching

* Apply suggestions from code review

Co-authored-by: Lovepreet Singh <[email protected]>

* Address review comments

Co-authored-by: Lovepreet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lvpx lvpx lvpx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vsvipul vsvipul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phantsure @lvpx @vsvipul