Skip to content

Conversation

ELHoussineT
Copy link
Contributor

I think we should state here that restore-keys supports prefixes as it is mentioned here.

@ELHoussineT ELHoussineT requested a review from a team as a code owner September 22, 2022 08:51
@github-actions github-actions bot requested a review from vsvipul September 22, 2022 08:52
@ELHoussineT ELHoussineT changed the title Indicate that restore-keys uses prefix in README docs: Indicate that restore-keys uses prefix in README Sep 22, 2022
@vsvipul vsvipul self-assigned this Sep 28, 2022
@vsvipul
Copy link
Contributor

vsvipul commented Oct 3, 2022

I'm not sure if this is required. The line An ordered list of keys to use for restoring stale cache if no cache hit occurred for key already signifies what you are trying to add.

@vsvipul vsvipul closed this Oct 3, 2022
@ELHoussineT
Copy link
Contributor Author

@vsvipul "list of keys" does not disclose that the keys can be prefixes to the keys.

@vsvipul
Copy link
Contributor

vsvipul commented Oct 3, 2022

@ELHoussineT Yes, I agree. In that case can we change that line itself to indicate that restore-keys are prefix matched?

@vsvipul vsvipul reopened this Oct 3, 2022
@vsvipul
Copy link
Contributor

vsvipul commented Oct 3, 2022

Something like An ordered list of prefix-matched keys to use for restoring stale cache if no cache hit occurred for key

@ELHoussineT
Copy link
Contributor Author

@vsvipul good idea.

Copy link
Contributor

@vsvipul vsvipul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vsvipul
Copy link
Contributor

vsvipul commented Oct 3, 2022

Thank you for contributing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants