Skip to content

Conversation

rosik
Copy link
Contributor

@rosik rosik commented Jan 19, 2021

  • Print primary key when saving cache

This is a follow-up for actions/toolkit#650
Close #471

@rosik
Copy link
Contributor Author

rosik commented Jan 19, 2021

@yacaovsnc @konradpabjan Here is one more change necessary for closing #471, but I couldn't manage how to update the toolkit dependency. Could you guide me, please?

@rosik rosik mentioned this pull request Jan 19, 2021
@konradpabjan
Copy link
Contributor

@rosik we need to bump up the version in the toolkit and then publish it so the changes are here: https://www.npmjs.com/package/@actions/cache

I'll take care of publishing a new version this week.

After that you update package.json and package_lock.json in this repo and the changes will get picked.

@rosik
Copy link
Contributor Author

rosik commented Jan 20, 2021

@konradpabjan ok, thanks.

@konradpabjan
Copy link
Contributor

Apologies for the delay. I've published a new version of @actions/cache with some other changes: https://www.npmjs.com/package/@actions/cache/v/1.0.6

@rosik rosik marked this pull request as ready for review February 2, 2021 21:32
@rosik rosik requested a review from a team as a code owner February 2, 2021 21:32
@konradpabjan
Copy link
Contributor

konradpabjan commented Feb 3, 2021

I've updated @actions/cache to version 1.0.6 in a separate PR since there were a lot of changes with the files under dist/* and I had to update quite a bit of licenses to make CI go green: #525

Could you resolve the merge conflicts in your PR? We can get the other changes in

- Print primary key when saving cache
@rosik
Copy link
Contributor Author

rosik commented Feb 3, 2021

@konradpabjan done.

Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@konradpabjan konradpabjan merged commit 26968a0 into actions:main Feb 3, 2021
@konradpabjan
Copy link
Contributor

Thanks again for all the contributions and sorry for the delays on our side.

I'm going to wait until tomorrow before updating any tags or creating a new release ( last-minute sanity check after larger changes go in). Quite a bit of users use @main so if something is wrong we'll notice before the changes hit everyone.

This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make action more verbose

2 participants