Allow to skip the save post-step #489
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ runs: | |
| using: 'node12' | ||
| main: 'dist/restore/index.js' | ||
| post: 'dist/save/index.js' | ||
| post-if: success() && env.CACHE_SKIP_SAVE != 'true' | ||
|
There was a problem hiding this comment. My only suggestion would be to have a more specific environment variable here. Something like There was a problem hiding this comment. @roni-frantchi, would you be able to pick this up? Would be great to get this merged! |
||
| branding: | ||
| icon: 'archive' | ||
| color: 'gray-dark' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is the default example and skipping cache save is a special case, I wouldn't include this here. Perhaps move this into the Examples.md file and we can add some specific examples of where this is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we can also highlight in the example is how users can either set this on the cache step as shown here or using
echo "CACHE_SKIP_SAVE=true" >> $GITHUB_ENV.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes you've suggested on the readme file capture it well enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roni-frantchi & @dhadka, would be great if this PR could be merged to reduce the workflow runtime when a cache-update isn't required. Seems like only a small adjustment would be needed?
Not sure if this issue could be addressed in this PR too: skipping the post-step altogether when there was a cache-hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it can either...
Seeing so many are expecting it, maybe we should explore doing it on another PR?..
Sorry @rene-leanix it's been a while - what adjustment would that be?..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roni-frantchi, I was just referring to @dhadka's comments above in this thread: here and here.