Adds input for upload chunk size #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
reviewed
Oct 2, 2020
There was a problem hiding this comment.
We'll need to document this as an optional input in the action.yml file
joshmgross
reviewed
Oct 2, 2020
action.yml
Outdated
| description: 'An ordered list of keys to use for restoring the cache if no cache hit occurred for key' | ||
| required: false | ||
| upload-chunk-size: | ||
| description: 'The chunk size used when uploading large cache files' |
There was a problem hiding this comment.
We should include the unit in either the description or input name (upload-chunk-size-bytes)
joshmgross
approved these changes
Oct 2, 2020
aiqiaoy
approved these changes
Oct 2, 2020
|
@aiqiaoy No particular reason. If I had to give a reason, it would be for simplicity. This puts all arguments under |
KTibow
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds input to limit the upload chunk size. This is useful for self-hosted runners with limited upload speeds, as an upload taking longer than the server timeout will fail. We used to have this configurable via an environment variable, but that was removed when splitting the cache action out into the cache module.
Fixes #415