This repository was archived by the owner on Mar 16, 2024. It is now read-only.
Enable generating endpoints with paths and exposing job ports. #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a path field to container ports so that users can specify an optional path to append to container's endpoint URL. The path field supports interpolation which, for example, enables the use of runtime generated tokens. Signed-off-by: Nick Hale <[email protected]>
Deploy ServiceInstances and Ingresses for job ports. This allows jobs to serve traffic and expose things like temporary web pages for collecting user credentials. Signed-off-by: Nick Hale <[email protected]>
Signed-off-by: Nick Hale <[email protected]>
thedadams
approved these changes
Nov 4, 2023
Contributor
thedadams
left a comment
There was a problem hiding this comment.
Looks good. Great job!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a path field to container ports so that users can specify an
optional path to append to container's endpoint URL. The path field
supports interpolation which, for example, enables the use of runtime
generated tokens.
Additionally, deploy ServiceInstances and Ingresses for job ports. This
allows jobs to serve traffic and expose things like temporary web pages
for collecting user credentials.
e.g. Adding a port with an interpolated path to a job:
Will result in an app endpoint that stays active until the job completed (or the app is stopped)