Skip to content

Fix --stop-at-end for piped input #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix --stop-at-end for piped input #347

wants to merge 1 commit into from

Conversation

@jonscheiding
Copy link

@jonscheiding jonscheiding commented Jul 10, 2025 •
edited
Loading

The --stop-at-end flag doesn't work when piping input.

$(gource --log-command git) > repo.log

# Exits as expected
gource --stop-at-end repo.log

# Never exits
cat repo.log | gource --stop-at-end --log-format git -

After building with this change, we can see:

$(gource --log-command git) > repo.log

# Exits as expected
gource --stop-at-end repo.log

# Exits as expected
cat repo.log | gource --stop-at-end --log-format git -

We also see that tail -f repo.log | gource --stop-at-end --log-format git - exits, which IMO it should not. This is addressed by acaudwell/Core#14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonscheiding