feat: enhanced service account support #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3f732e to
0c3fe1a
Compare
0c3fe1a to
c1e936d
Compare
c1e936d to
2b33115
Compare
2b33115 to
1b6fe9c
Compare
1b6fe9c to
0709ab7
Compare
0709ab7 to
0fdd60a
Compare
0fdd60a to
a2e7e3c
Compare
a2e7e3c to
adccf1c
Compare
drevell
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things.
GCP service account audience change
Closes #218 - The original service account implementation required that the org/repo name be set as the audience on the OIDC token generated for the service account. This made it impossible to use a single token to both authenticate with cloud run AND as the exchange token. Now that we have the org name as one of the request object attributes we can do away with the inconsistent use of the audience field. As a side effect, the logic for parsing the audience had a hard coded github.com value which make this not work in Enterprise Server deployments.
Simple token exchange CLI
Added a simplistic CLI option to execute the call to minty from the command line. This opens up a number of options for potentially replacing the javascript based GitHub action in the future and also creates the potential to generate tokens from other scripts and tools that run as service accounts.
CLI command cleanup
The CLI command structure was strange. There were multiple tools that ended up as single commands with multi word invocations like
private-key import,config validate. Migrated all non-server commands, including the new one, under atoolstop level heading.