Assess OTP2 upgrade #1392
Merged
Assess OTP2 upgrade #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rajadain
requested changes
Feb 27, 2025
| The next major release, OTP2, not only supports the updated GTFS format but addresses routing performance issues and includes passenger-facing itinerary services. This version update would introduce stability into our data deployment process and may provide better support for any incoming transit feed format revisions in the future. However, OTP2 is a complete rewrite that has a more limited, focused feature set so it may not be possible to use with our application. This ADR is to evaluate the feasibility of this major version upgrade and come to a go/no-go conclusion. | ||
|
|
||
|
|
||
| ### Evaluation criteria |
There was a problem hiding this comment.
Prefer using one blank line between headings, paragraphs. Currently, sometimes we use two blank lines, sometimes one, and sometimes none.
doc/adr-001-otp2-update-eval.md
Outdated
|
|
||
|
|
||
| - Compile and build a transportation network graph for the greater Philadelphia region using the following sources: | ||
| - SEPTA, PATCO, NJTransit, and DART GTFS* feeds |
There was a problem hiding this comment.
Consider using a proper Markdown footnote here.
doc/adr-001-otp2-update-eval.md
Outdated
| - Supports all core features currently in use by GoPhillyGo | ||
| - Maintenance and security support through current contract | ||
| - Supports current GTFS and GBFS standard formats | ||
| - Lift to adapt codebase to OTP setup/run commands, server and graph configuration, and REST API are feasible within remaining time and budget |
There was a problem hiding this comment.
Suggested change
| - Lift to adapt codebase to OTP setup/run commands, server and graph configuration, and REST API are feasible within remaining time and budget | |
| - Effort to adapt codebase to OTP setup/run commands, server and graph configuration, and REST API is feasible within remaining time and budget |
95bae26 to
0b37d2e
Compare
@rajadain , thank you for the review! I just addressed those edits, this is ready for another look. Noting that I rebased with develop following the recent monthly release. |
rajadain
approved these changes
Mar 6, 2025
doc/adr-001-otp2-update-eval.md
Outdated
| - Aligned with GTFS and GBFS feed formats and likely will maintain alignment | ||
| - More efficient graph building and performant routing | ||
|
|
||
| **Cons** |
There was a problem hiding this comment.
Suggested change
| **Cons** | |
| **Cons:** |
0b37d2e to
567cfcd
Compare
|
Thank you for the review! I captured that last grammatical fix in the latest commit following rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Assesses upgrade to OpenTripPlanner 2 and compile notes into decision ADR. Decision summary: OTP2 does not have support for core application features so we will not be moving forward with the major version upgrade, although there is a minor version upgrade for OTP1 that is the "final release" and includes backported bugfixes.
Notes
I started building a diagram to better understand how this project utilizes trip planning requests to OTP and its graph-building process, but it may adjust as I get deeper into #1385 so I will include that finished diagram as part of that PR as a README in this new
docdirectory.Connects #1355