Skip to content

Feature/kak/social sharing improvements#1021 #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2018
Merged

Feature/kak/social sharing improvements#1021 #1062

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
018b085
Use absolute, full URL for Open Graph
flibbertigibbet Aug 3, 2018
44d6122
Use full path for social sharing images
flibbertigibbet Aug 3, 2018
4aa29dc
Bump OTP ansible role version
flibbertigibbet Aug 6, 2018
4ae0ec2
Add image alt tags for social sharing
flibbertigibbet Aug 6, 2018
3a429f4
Use social sharing logo
flibbertigibbet Aug 6, 2018
be0ad3c
Link to privacy policy and TOS in footer
flibbertigibbet Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use full path for social sharing images 
Use full path for social sharing meta tags for place and event detail images.
Fixes #1021.
  • Loading branch information
@flibbertigibbet
flibbertigibbet committed Aug 3, 2018
commit 44d61221a79e1e3dff9847686ae3ef89465b0711
4 changes: 2 additions & 2 deletions python/cac_tripplanner/templates/event-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
<meta name="twitter:site" content="@go_philly_go" />
<meta property="og:description" content="{{ event.description|striptags }}" />
<meta name="twitter:description" content="{{ event.description|striptags }}" />
<meta property="og:image" content="{% cropped_thumbnail event 'wide_image' %}" />
<meta name="twitter:image" content="{% cropped_thumbnail event 'wide_image' %}" />
<meta property="og:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail event 'wide_image' %}" />
<meta name="twitter:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail event 'wide_image' %}" />
<meta property="og:image:width" content="680" />
<meta property="og:image:height" content="400" />
{% endblock %}
Expand Down
4 changes: 2 additions & 2 deletions python/cac_tripplanner/templates/learn-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
<meta name="twitter:site" content="@go_philly_go" />
<meta property="og:description" content="{{ article.teaser|striptags }}" />
<meta name="twitter:description" content="{{ article.teaser|striptags }}" />
<meta property="og:image" content="{% cropped_thumbnail article 'wide_image' %}" />
<meta name="twitter:image" content="{% cropped_thumbnail article 'wide_image' %}" />
<meta property="og:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail article 'wide_image' %}" />
<meta name="twitter:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail article 'wide_image' %}" />
<meta property="og:image:width" content="680" />
<meta property="og:image:height" content="200" />
{% endblock %}
Expand Down
4 changes: 2 additions & 2 deletions python/cac_tripplanner/templates/place-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
<meta name="twitter:site" content="@go_philly_go" />
<meta name="twitter:description" content="{{ destination.description|striptags }}" />
<meta property="og:description" content="{{ destination.description|striptags }}" />
<meta property="og:image" content="{% cropped_thumbnail destination 'wide_image' %}" />
<meta name="twitter:image" content="{% cropped_thumbnail destination 'wide_image' %}" />
<meta property="og:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail destination 'wide_image' %}" />
<meta name="twitter:image" content="{{ request.build_absolute_uri }}{% cropped_thumbnail destination 'wide_image' %}" />
<meta property="og:image:width" content="680" />
<meta property="og:image:height" content="400" />
{% endblock %}
Expand Down