Feature/replace jquery storage api #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is another jshintrc in app/scripts/src, so remove this one.
Closes azavea#517. Replace deprecated jQuery-Storage-API with js-storage.
Fixes linter warnings. Remove method and marker for current user location, which are no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #517, replace deprecated JS library for local storage usage. Also removes extraneous JSHint configuration file and fixes a linter warning that had been hidden by it.
The new js-storage library offers to handle encoding/decoding JSON automatically, but it handles arrays strangely (returning them as a dictionary with numbered keys), so I left in our existing encoding/decoding logic.