Feature/store waypoints #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not reverse waypoints when arriveBy is true. (Done in attempt to address broken results when arriveBy is true and transit mode not selected.
Closes azavea#499. Stores user-added waypoints (modified places on an edited route) in local storage. Puts waypoints in the URL also. Cleared on origin or destination change, or other events that cause all itineraries to be cleared from the map.
|
build again |
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #499.
Stores user-added waypoints (modified places on an edited route) in local storage.
Puts waypoints in the URL also. Cleared on origin or destination change,
or other events that cause all itineraries to be cleared from the map.
To test, edit a route. New
waypointsshould be set in local storage and in URL; edited route should be preserved on page refresh. Shortened link URL should containintermediatePlacesparameter.Does not yet preserve previously edited waypoints on subsequent route edits, as we will need to implement #502 to be able to easily get the ordering right.