Run travis tests against 3 different ansible versions #7
Conversation
SuperQ
left a comment
There was a problem hiding this comment.
Yes, I think we can drop the test-requirements.txt file now.
.travis.yml
Outdated
| # Install ansible, molecule, and dependencies | ||
| install: | ||
| - pip install -r test-requirements.txt | ||
| - pip install ${ANSIBLE} 'molecule>=2.15.0' docker 'ansible-lint>=3.4.0' 'testinfra>=1.7.0' |
There was a problem hiding this comment.
I think the docker package already includes molecule now, we can probably drop that as well.
There was a problem hiding this comment.
Docker package includes molecule? That doesn't seem to be right.
There was a problem hiding this comment.
Sorry, the images used for testing, ie. image: paulfantom/centos-molecule already include it.
There was a problem hiding this comment.
But docker is needed by ansible to provision this image. CI fails without it (https://travis-ci.org/atosatto/ansible-minio/builds/396310266)
There was a problem hiding this comment.
No, I meant removing the molecule package, not the docker package. But I guess those are not included in the base travis image.
Nevermind!
There was a problem hiding this comment.
Yeah, molecule isn't installed by default in travis.
|
Why don't we use tox as done, e.g., in http://github.com/atosatto/ansible-caddy? |
|
I don't have much experience with tox. @atosatto can you parallelize tox execution over multiple travis instances? |
729b10f to
3d98143
Compare
|
@atosatto tox looks so much better! I need to port it to @cloudalchemy 😄 |
|
😄 |
|
I don't see any protests, merging :) |
dockerpackage instead ofdocker-pyas it was renamed (http://docker-py.readthedocs.io/en/stable/)@atosatto can we remove test-requirements.txt?