PHP 8.4 compatability: Make parameter types explicitly nullable #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice if this got merged :) |
matthi4s
approved these changes
Aug 6, 2025
Soapy7261
added a commit
to Soapy7261/yolks
that referenced
this pull request
Aug 12, 2025
Thanks for merging the PR matthias! aternosorg/codex#23 Only took.. ~9 months!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.4 implicitly marking parameters as nullable is deprecated. This PR explicitly marks the parameters as nullable by adding a
?to the parameter types with a default value of null (= null).