OHRM5X-2609: Fix general defects #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validate emails in ResetPasswordService.php - sanitize user names in ResetPasswordService.php - add new page for email failures - route to new page in RequestResetPasswordController.php
- get resetCode as a hidden input - use existing validation of reset code to check for modified usernames
- add isEntityAccessible check into attachment controller
- add user active check to auth subscriber and logout if not
RajithaKumara
requested changes
Oct 21, 2025
src/plugins/orangehrmAuthenticationPlugin/Subscriber/AuthenticationSubscriber.php
Show resolved
Hide resolved
- add checks for terminated employee
…event conflict with new logout logic
- store auth user last modified as session variable - log out user if session last modified differs from db last modified - update UpdatePasswordAPI to set last modified - route on update password screen to trigger session expiry - add "Session Expiry" lang string
- add work email validation to FE and API
- validate email in email service
RajithaKumara
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for