Remind count of map and add benchmark #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1eks3y
reviewed
Mar 14, 2025
Comment on lines
+73
to
74
| b := len(shard.items) | ||
| shard.Lock() |
There was a problem hiding this comment.
You need to move it inside lock, because length can be changed by another thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old:
BenchmarkCount
BenchmarkCount-8 2150287 514.2 ns/op
the new:
BenchmarkCount
BenchmarkCount-8 393898780 2.755 ns/op
And otherwise ,the insert from
the new
BenchmarkItems-8 278 4242234 ns/op
the old
BenchmarkItems-8 258 4090206 ns/op
Fixes: #143