fix(ai-native): use path.join for wasm file paths in WasmModuleManager #4304

nxps · 2025-01-06T11:04:34Z

Types

🐛 Bug Fixes

Background or solution

解决请求 tree-sitter-wasm 资源 404 问题.

opensumi 3.7.0 版本, AppConfig 配置如下时:

{
    componentCDNType: 'npmmirror'
}

会出现 url path 错误, 导致请求 https://registry.npmmirror.com/@opensumi/tree-sitter-wasm/0.0.2/files//tree-sitter.wasm 404.

相关源码:
https://github.com/opensumi/core/blob/v3.7/packages/core-browser/src/react-providers/config-provider.tsx#L390

Changelog

Summary by CodeRabbit

改进
- 优化了 WebAssembly (WASM) 文件路径的处理方法
- 使用 path.join() 方法替代字符串拼接，提高路径构建的可靠性和跨平台兼容性

coderabbitai · 2025-01-06T11:06:51Z

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

变更概览

演练

此次变更主要修改了 WebAssembly (WASM) 文件路径的构建方式。在 wasm-manager.ts 文件中，开发者从 @opensumi/ide-utils 模块导入了 path 方法，并使用 path.join() 替换了原有的字符串拼接方法来构造 wasmPath 和 wasmUrl 变量。这一变更旨在改进 WASM 文件路径的处理方式。

变更

文件	变更摘要
`packages/ai-native/src/browser/languages/tree-sitter/wasm-manager.ts`	1. 新增 `path` 导入 2. 使用 `path.join()` 替换字符串拼接构建 WASM 文件路径

可能相关的 PR

feat: use async in watch file changes #4026：涉及路径解析和异步处理，可能与 WASM 文件路径处理相关
fix: terminal open link on changed cwd #4188：增强基于终端当前工作目录的路径管理，与改进 WASM 文件路径处理方向一致

建议标签

🐞 bug

建议审阅者

Ricbet

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/ai-native/src/browser/languages/tree-sitter/wasm-manager.ts (2)

32-32: 使用 path.join 拼接 wasm 路径能有效避免重复斜杠等路径问题。

如果 baseUrl 具有可能不一致的末尾斜杠或空字符串，这种方式更健壮且可读性更高。建议后续在运行环境或测试环境中验证最终生成的完整 URL 是否正确。

48-48: 同样使用 path.join 拼接语言相关的 wasm 文件路径，非常直观且一致。

建议在使用 fetch 时考虑错误处理，例如网络异常或文件不存在等情况，保证在发生异常时能够及时向上层抛出或记录错误日志。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 826fcf0 and 772a0d4.

📒 Files selected for processing (1)

packages/ai-native/src/browser/languages/tree-sitter/wasm-manager.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: ubuntu-latest, Node.js 20.x
GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
GitHub Check: build (ubuntu-latest, 20.x)
GitHub Check: unittest (ubuntu-latest, 18.x, node)
GitHub Check: build (macos-latest, 20.x)
GitHub Check: unittest (macos-latest, 18.x, jsdom)
GitHub Check: build-windows
GitHub Check: unittest (macos-latest, 18.x, node)

🔇 Additional comments (1)

packages/ai-native/src/browser/languages/tree-sitter/wasm-manager.ts (1)

5-5: 导入 path 很实用！

此更改能够帮助以一致的方式处理路径拼接，避免了手动字符串连接可能带来的潜在路径问题。

codecov · 2025-01-06T11:19:07Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (826fcf0) to head (772a0d4).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/browser/languages/tree-sitter/wasm-manager.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4304      +/-   ##
==========================================
- Coverage   54.20%   54.20%   -0.01%     
==========================================
  Files        1634     1634              
  Lines       99927    99927              
  Branches    21700    21692       -8     
==========================================
- Hits        54169    54167       -2     
- Misses      38015    38016       +1     
- Partials     7743     7744       +1

Flag	Coverage Δ
jsdom	`49.74% <33.33%> (-0.01%)`	⬇️
node	`12.24% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erha19

LGTM

erha19 · 2025-01-09T11:06:58Z

packages/ai-native/src/browser/languages/tree-sitter/wasm-manager.ts

  async initParser() {
    const baseUrl = await this.resolvedResourceUriDeferred.promise;
-    const wasmPath = `${baseUrl}/tree-sitter.wasm`;
+    const wasmPath = path.join(baseUrl, 'tree-sitter.wasm');


@nxps 这里的修改存在问题，框架内的 path.join 会将 https:// 类似格式转化为 https:/ 导致问题，已在 6b17497 修复

fix(ai-native): use path.join for wasm file paths in WasmModuleManager

772a0d4

opensumi bot added the 🐞 bug Something isn't working label Jan 6, 2025

coderabbitai bot reviewed Jan 6, 2025

View reviewed changes

erha19 approved these changes Jan 7, 2025

View reviewed changes

erha19 merged commit 3b751c9 into opensumi:main Jan 7, 2025
12 of 13 checks passed

coderabbitai bot mentioned this pull request Jan 9, 2025

fix: debug toolbar is disappeared or session paused after debug session started #4312

Merged

1 task

erha19 reviewed Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ai-native): use path.join for wasm file paths in WasmModuleManager #4304

fix(ai-native): use path.join for wasm file paths in WasmModuleManager #4304

Uh oh!

nxps commented Jan 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 6, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Jan 6, 2025 •

edited

Loading

Uh oh!

erha19 left a comment

Uh oh!

Uh oh!

erha19 Jan 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(ai-native): use path.join for wasm file paths in WasmModuleManager #4304

fix(ai-native): use path.join for wasm file paths in WasmModuleManager #4304

Uh oh!

Conversation

nxps commented Jan 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types

Background or solution

Changelog

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 6, 2025

变更概览

演练

变更

可能相关的 PR

建议标签

建议审阅者

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

erha19 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erha19 Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nxps commented Jan 6, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jan 6, 2025 •

edited

Loading