Fix SecretKey.prototype.makeDummy() #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df47701 to
4b60f40
Compare
|
I'm not a maintainer here but still I'd like to thank you for these contributions lately 👍 |
4b60f40 to
709cc0b
Compare
709cc0b to
ee5be61
Compare
larabr
added a commit
that referenced
this pull request
Jan 13, 2021
Keys converted using makeDummy() were not serialised correctly as they were treated as unencrypted keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys converted using
makeDummy()were not serialised correctly as they were treated as unencrypted keys.