Script DSL: do implicit import java.time.temporal.ChronoUnit;
#5098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import java.time.temporal.ChronoUnit;
98e08bd to
cf8e4bc
Compare
Contributor
|
Thanks. |
Contributor
|
@dilyanpalauzov : I am afraid none of your PRs will be accepted by @openhab/core-maintainers because they are not signed as requested. |
kaikreuzer
approved these changes
Dec 6, 2025
Member
kaikreuzer
left a comment
There was a problem hiding this comment.
Thanks for the investigation and the fix.
With two simple lines, I am ok to merge this without DCO as a small patch exception.
Contributor
Contributor
Yes, it does solve the issue for Unfortunately not. It looks like it always treats the nested enum as a field when using file defined rules, whatever I try, including the pattern as in this PR. I probably miss something obvious but I don't see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current addition:
corresponds to having in DSL scripts/rules implicit:
import java.time.temporal.ChronoUnit;, whereas(cutting
, "ChronoUnit"and toggling the middle parameter), would correspond toimport java.time.temporal.*;.The reason why
DayOfWeek.MONDAYandlogError("A", MonthDay.now.toString)(⇔MonthDay.now()) work is, becauseScriptImportSectionNamespaceScopeProvider.java:getImplicitImports()containsimplicitImports.add(doCreateImportNormalizer(QualifiedName.create("java", "time"), true, false));corresponding to implicitimport java.time.*;in DSL scripts.N.B. As the result of ScriptImplicitlyImportedTypes.java:getStaticImportClasses() includes
ChronoUnit.classandDayOfWeek.class, DSL Scripts have implicitimport static java.time.temporal.ChronoUnit.*; import static java.time.DayOfWeek.*;. For this reason justTUESDAYandDAYSin Script DSL are recognized.Closes #4791.